[fix][broker] fix flaky test in SystemTopicBasedTopicPoliciesServiceTest #25098
Conversation
| logger.addAppender(appender); | ||
| @Cleanup | ||
| TestLogAppender testLogAppender = | ||
| TestLogAppender.create(Optional.of("SystemTopicBasedTopicPoliciesService")); |
There was a problem hiding this comment.
I think that this would attach to the root logger since SystemTopicBasedTopicPoliciesService wouldn't be found. The logger name is the full class name.
Please improve TestLogAppender and add a .create(Class<?> loggerNameClass) method to simplify the creation. It could delegate to create(Optional.of(loggerNameClass.getName())).
There was a problem hiding this comment.
Replace to TestLogAppender testLogAppender = TestLogAppender.create(Optional.of(SystemTopicBasedTopicPoliciesService.class.getName())); ?
There was a problem hiding this comment.
That would work, but please modify TestLogAppenderand add a new method there (.create(Class<?> loggerNameClass)). That way it will be cleaner. TestLogAppender can be improved in PRs when there are new use cases for improvements.
3 participants
Main Issue: #25081
Motivation
fix for flaky test.
Modifications
Verifying this change
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete